Gecko/AR Batch Approval #13204
Gecko/AR Batch Approval #13204
Conversation
|
For something like G2V, if a setting affects all 3 regions, then it goes into G2V, then you can create the 3 region specific INIs for the region specific codes and Dolphin will construct it accordingly. You can see this in other games that have specific settings in the "global" INI and then the cheats placed into the 6 character ini. |
Data/Sys/GameSettings/GALE01r0.ini
Outdated
| [Gecko_RetroAchievements_Verified] | ||
| $Proper 16:9 Widescreen Support [Dan Salvato, mirrorbender] | ||
| $Properly Display in 4:3 [Dan Salvato, mirrorbender] | ||
| $Normal C Stick Functionality in Singleplayer Modes [Zauron] |
There was a problem hiding this comment.
Are you sure you want to allow normal C stick functionality in single player? Unlike the other codes you're allowlisting in this PR, this makes the game easier to play.
There was a problem hiding this comment.
RetroAchievements does have a patch for this. Because the C-Stick is so integral to Melee at this point, it's considered a standard part of the gameplay and is core to how most people play the game nowadays.
There was a problem hiding this comment.
As a Melee player myself, I see both sides of the argument. I'd think keeping original game behavior by default is more in the spirit of Dolphin though.
There was a problem hiding this comment.
This isn't about defaulting it, this change will let RetroAchievements players use it instead of locking them into original.
LillyJadeKatrin
force-pushed
the
retroachievements-allow-batch
branch
2 times, most recently
from
472f04f to
615eb86
Compare
Data/Sys/GameSettings/GJX.ini
Outdated
| # Add action replay cheats here. | ||
| $Disable Culling | ||
| 04011A14 60000001 | ||
| 04011A18 4E800020 |
There was a problem hiding this comment.
Are you sure this code works on all versions of the game? If not, it should be in a six-character INI file.
There was a problem hiding this comment.
The wiki does not specify. https://wiki.dolphin-emu.org/index.php?title=Vexx I am unable to verify this because I don't own a copy of it.
There was a problem hiding this comment.
I'm not comfortable with this unless someone verifies it works in both.
LillyJadeKatrin
force-pushed
the
retroachievements-allow-batch
branch
4 times, most recently
from
424eb42 to
c23e781
Compare
New code adds a test failure if there's a Patches/Gecko/AR_Retroachievements_Verified code that doesn't appear to actually exist in the file. This will catch if the allowed patch is formatted wrong, which I found happening several times already due to not realizing that the patch author's name would need to be omitted.
LillyJadeKatrin
force-pushed
the
retroachievements-allow-batch
branch
from
c23e781 to
f2305fc
Compare
Data/Sys/GameSettings/G8MJ01.ini
Outdated
| @@ -0,0 +1,40 @@ | |||
| # G8MJ01 - Paper Mario | |||
There was a problem hiding this comment.
I know the existing INI has the wrong name, but we should use the official name in all three imo.
Data/Sys/GameSettings/G8MP01.ini
Outdated
| @@ -0,0 +1,40 @@ | |||
| # G8MP01 - Paper Mario | |||
Data/Sys/GameSettings/GEZE8P.ini
Outdated
| @@ -0,0 +1,42 @@ | |||
| # GEZE8P - BillyHatcher | |||
There was a problem hiding this comment.
Maybe not for this PR but more and more the old INIs have names that are bugging me.
Data/Sys/GameSettings/GJX.ini
Outdated
| # Add action replay cheats here. | ||
| $Disable Culling | ||
| 04011A14 60000001 | ||
| 04011A18 4E800020 |
There was a problem hiding this comment.
I'm not comfortable with this unless someone verifies it works in both.
Adding a community-requested list of Gecko and Action Replay codes to the allowlist. Many of these codes were from the wiki and are being added to Dolphin's repo for the first time.
LillyJadeKatrin
force-pushed
the
retroachievements-allow-batch
branch
from
f2305fc to
a1f2f3c
Compare
|
I scanned through everything and didn't see anything outright blocking, but with this number of files it's entirely possible I might have missed something. |
| @@ -31,3 +31,74 @@ EnableGPUTextureDecoding = False | |||
|
|
|||
| [Video_Enhancements] | |||
| ArbitraryMipmapDetection = True | |||
|
|
|||
| [Gecko] | |||
| $Bloom x4 IR | |||
There was a problem hiding this comment.
This shouldn't be in a three-character INI unless it has been tested to be region free.
Adding a community-requested list of Gecko and Action Replay codes to the allowlist. Many of these codes were from the wiki and are being added to Dolphin's repo for the first time.