Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoCommon: cache the per-vertex position/normal matrix index #13227

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tilka
Copy link
Member

@Tilka Tilka commented Dec 16, 2024

Seems like the position/normal matrix index is also cached (or its resulting matrices, I haven't tested that yet).

I'm not completely happy about the fix yet, but let's get a CI run.

@Tilka Tilka requested a review from Pokechu22 December 16, 2024 01:14
@Pokechu22
Copy link
Contributor

Image from hardware fifoplayer - the mp2 diffs are definitely a bug:

1_y0_x0

@MayImilae
Copy link
Contributor

Pokechu beat me to it, but here's a hardware test of me just walking up to the spot and getting an approximate recreation.

mp1-boxes

Confirmed the previous behavior was correct. However, since I'm just in the game, I can move around. Here's the scene from another angle.

mp2-boxes2

The fifolog camera position is to the left of this view. Here, we can see all four boxes that are shown in the fifolog. As is pretty obvious looking at it like this, the top box of the triad of boxes is definitely in view and should be lit. At the very least lit like the boxes below it. The fact that it is not highlighted or lit at all is definitely incorrect.

@Tilka Tilka changed the title VertexCommon: cache the per-vertex position/normal matrix index VideoCommon: cache the per-vertex position/normal matrix index Dec 24, 2024
@dolphin-ci
Copy link

dolphin-ci bot commented Dec 24, 2024

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

  • mp2-scanner on ogl-lin-mesa: diff
  • mp2-scanner on sw-lin-mesa: diff
  • mp2-scanner on mvk-osx-m1: diff
  • mp2-scanner on mtl-osx-m1: diff
  • mp2-scanner on vk-lin-mesa: diff

automated-fifoci-reporter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants