Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve import best practices. #1699

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Improve import best practices. #1699

merged 1 commit into from
Aug 30, 2023

Conversation

nicktobey
Copy link
Contributor

This PR updates the Import Best Practices for advice for using writing their own .sql scripts for importing data into a Dolt repo.

Essentially:

  • Import one table at a time.
  • Prefer fewer INSERT statements that each insert multiple values over more, shorter statements that only insert a single value each.
  • Sort your inserts by primary key. If a table doesn't have a primary key, consider adding one.

timsehn
timsehn approved these changes Aug 30, 2023
View reviewed changes
Copy link
Sponsor Contributor

@timsehn timsehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicktobey nicktobey merged commit 98a4a0d into gitbook-dev Aug 30, 2023
@tbantle22 tbantle22 deleted the nicktobey/bestpractices branch October 6, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timsehn timsehn timsehn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicktobey @timsehn