Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark More SQL Funcs as Supported #2346

Merged
merged 6 commits into from
Sep 20, 2024
Merged

Mark More SQL Funcs as Supported #2346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f1546f2
mark charset as supported
Sep 16, 2024
16009ae
updating count
Sep 18, 2024
0a9ca0b
correctness
Sep 18, 2024
17107c7
marking compressed funcs as supported
Sep 19, 2024
e65d30a
compress note
Sep 19, 2024
11350a4
adding validate password strength
Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/dolt/content/reference/sql/benchmarks/correctness.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,14 @@ We also measure the coverage of the functions in the SQL engine. This
is a measure of how many of the supported MySQL functions are also
supported by Dolt.

Here are Dolt's function coverage results for version `1.42.18`.
Here are Dolt's function coverage results for version `1.42.20`.
| Supported | Total | Percent Coverage |
|-----------|-------|------------------|
| 310 | 431 | 72 |
| 316 | 431 | 73 |

## Skipped Engine Tests
Here are the total number of tests skipped by the engine for
version `1.42.18`. These are edge cases that we know are failing for
version `1.42.20`. These are edge cases that we know are failing for
one reason or another, but haven't been able to fix yet.

In general, these tests are more difficult to fix compared to
Expand Down
14 changes: 7 additions & 7 deletions packages/dolt/content/reference/sql/sql-support/expressions-functions-operators.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ title: "Expressions, Functions, and Operators"

## Functions and operators

**Currently supporting 310 of 431 MySQL functions.**
**Currently supporting 316 of 431 MySQL functions.**

Most functions are simple to implement. If you need one that isn't implemented, [please file an issue](https://github.com/dolthub/dolt/issues). We can fulfill most requests for new functions within 24 hours.

Expand Down Expand Up @@ -114,12 +114,12 @@ Most functions are simple to implement. If you need one that isn't implemented,
| `CEILING()` | ✅ | |
| `CHAR()` | ✅ | |
| `CHARACTER_LENGTH()` | ✅ | |
| `CHARSET()` | ❌ | |
| `CHARSET()` | ✅ | |
| `CHAR_LENGTH()` | ✅ | |
| `COALESCE()` | ✅ | |
| `COERCIBILITY()` | ✅ | |
| `COLLATION()` | ✅ | |
| `COMPRESS()` | ❌ | |
| `COMPRESS()` | ✅ | Golang's zlib library is slightly different than MySQL's, so compressed data may not match |
| `CONCAT()` | ✅ | |
| `CONCAT_WS()` | ✅ | |
| `CONNECTION_ID()` | ✅ | |
Expand Down Expand Up @@ -177,7 +177,7 @@ Most functions are simple to implement. If you need one that isn't implemented,
| `FROM_BASE64()` | ✅ | |
| `FROM_DAYS()` | ✅ | |
| `FROM_UNIXTIME()` | ✅ | |
| `GET_FORMAT()` | ❌ | |
| `GET_FORMAT()` | ✅ | |
| `GET_LOCK()` | ✅ | |
| `GREATEST()` | ✅ | |
| `GROUPING()` | ❌ | |
Expand Down Expand Up @@ -465,8 +465,8 @@ Most functions are simple to implement. If you need one that isn't implemented,
| `TRIM()` | ✅ | |
| `TRUNCATE()` | ❌ | |
| `UCASE()` | ✅ | |
| `UNCOMPRESS()` | ❌ | |
| `UNCOMPRESSED_LENGTH()` | ❌ | |
| `UNCOMPRESS()` | ✅ | |
| `UNCOMPRESSED_LENGTH()` | ✅ | |
| `UNHEX()` | ✅ | |
| `UNIX_TIMESTAMP()` | ✅ | |
| `UPPER()` | ✅ | |
Expand All @@ -478,7 +478,7 @@ Most functions are simple to implement. If you need one that isn't implemented,
| `UUID_SHORT()` | ❌ | |
| `UUID_TO_BIN()` | ✅ | |
| `UPDATEXML()` | ❌ | |
| `VALIDATE_PASSWORD_STRENGTH()` | ❌ | |
| `VALIDATE_PASSWORD_STRENGTH()` | ✅ | |
| `VALUES()` | ✅ | |
| `VARIANCE()` | ❌ | |
| `VAR_POP()` | ❌ | |
Expand Down