Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix minor log.Fatalln output #3894

Merged
merged 1 commit into from
Jul 22, 2022
Merged

fix minor log.Fatalln output #3894

merged 1 commit into from
Jul 22, 2022

Conversation

Abirdcfly
Copy link
Contributor

Signed-off-by: Abirdcfly fp544037857@gmail.com

log.Fatalln is equivalent to Println() followed by a call to os.Exit(1).

see example:

https://go.dev/play/p/VcdbrSNK6wH

package main

import (
	"log"
	"os"
)

func main() {
	log.Fatalln("A")
	log.Fatalln("B") // unreachable code
	os.Exit(2)
}

/* output:
2009/11/10 23:00:00 A

Program exited.
*/

Signed-off-by: Abirdcfly <fp544037857@gmail.com>
@timsehn
Copy link
Sponsor Contributor

timsehn commented Jul 22, 2022

Thanks for the PR. @bheni will look at this since he wrote this code.

Copy link
Contributor

@bheni bheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me. Thanks for the PR!

@bheni bheni merged commit 4f82061 into dolthub:main Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants