Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Uint32 for SEQ_IN_INDEX in 'SHOW INDEXES' queries. #2502

Merged
merged 3 commits into from
May 22, 2024
Merged

Use Uint32 for SEQ_IN_INDEX in 'SHOW INDEXES' queries. #2502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b3e762
Use Uint32 for SEQ_IN_INDEX in 'SHOW INDEXES' queries.
mkrautz May 19, 2024
2bc4b76
adding schema test
May 22, 2024
d8ddf45
formatting
May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions enginetest/queries/information_schema_queries.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,23 @@ var InfoSchemaQueries = []QueryTest{
},
{
Query: `SHOW INDEXES FROM mytaBLE`,
ExpectedColumns: sql.Schema{
&sql.Column{Name: "Table", Type: types.LongText},
&sql.Column{Name: "Non_unique", Type: types.Int32},
&sql.Column{Name: "Key_name", Type: types.LongText},
&sql.Column{Name: "Seq_in_index", Type: types.Uint32},
&sql.Column{Name: "Column_name", Type: types.LongText, Nullable: true},
&sql.Column{Name: "Collation", Type: types.LongText, Nullable: true},
&sql.Column{Name: "Cardinality", Type: types.Int64},
&sql.Column{Name: "Sub_part", Type: types.Int64, Nullable: true},
&sql.Column{Name: "Packed", Type: types.LongText, Nullable: true},
&sql.Column{Name: "Null", Type: types.LongText},
&sql.Column{Name: "Index_type", Type: types.LongText},
&sql.Column{Name: "Comment", Type: types.LongText},
&sql.Column{Name: "Index_comment", Type: types.LongText},
&sql.Column{Name: "Visible", Type: types.LongText},
&sql.Column{Name: "Expression", Type: types.LongText, Nullable: true},
},
Expected: []sql.Row{
{"mytable", 0, "PRIMARY", 1, "i", nil, 0, nil, nil, "", "BTREE", "", "", "YES", nil},
{"mytable", 0, "mytable_s", 1, "s", nil, 0, nil, nil, "", "BTREE", "", "", "YES", nil},
Expand Down
2 changes: 1 addition & 1 deletion sql/plan/show_indexes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ func (n *ShowIndexes) Schema() sql.Schema {
&sql.Column{Name: "Table", Type: types.LongText},
&sql.Column{Name: "Non_unique", Type: types.Int32},
&sql.Column{Name: "Key_name", Type: types.LongText},
&sql.Column{Name: "Seq_in_index", Type: types.Int32},
&sql.Column{Name: "Seq_in_index", Type: types.Uint32},
&sql.Column{Name: "Column_name", Type: types.LongText, Nullable: true},
&sql.Column{Name: "Collation", Type: types.LongText, Nullable: true},
&sql.Column{Name: "Cardinality", Type: types.Int64},
Expand Down