Adding mapping to error code 1049 for ErrDatabaseNotFound errors
#2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ping errors from ComInitDB to MySQL errors with error codes. dolthub/dolt#7890
fulghum
added a commit
to dolthub/dolt
that referenced
this pull request
May 23, 2024
fulghum
added a commit
to dolthub/dolt
that referenced
this pull request
May 23, 2024
This was referenced May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a database doesn't exist, MySQL returns error code 1049. This change adds a mapping to error code 1049 for
ErrDatabaseNotFounderrors, and updates our handler so thatComInitDBmessages will map errors to MySQL error codes.This is needed because tooling (e.g. Pomelo EntityFramework MySQL library) can rely on this error code in application logic.
Related to dolthub/dolt#7890