Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error message for invalid charset string #2763

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Better error message for invalid charset string #2763

merged 2 commits into from
Nov 23, 2024

Conversation

Hydrocharged
Copy link
Contributor

@Hydrocharged Hydrocharged commented Nov 23, 2024 •
edited
Loading

This is a followup to the comments on this PR:

@Hydrocharged Hydrocharged changed the title Better error message for bad string for charset Better error message for invalid charset string Nov 23, 2024
max-hoffman
max-hoffman approved these changes Nov 23, 2024
View reviewed changes
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Hydrocharged Hydrocharged merged commit d5eeb13 into main Nov 23, 2024
8 checks passed
@Hydrocharged Hydrocharged deleted the daylon/better-error branch November 23, 2024 04:14
@BrewTestBot BrewTestBot mentioned this pull request Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-hoffman max-hoffman max-hoffman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hydrocharged @max-hoffman