Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for serializing certain types in column default expressions #2825

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Jan 22, 2025

Fixed a couple bugs in column default normalization: 1) editing the expression tree in place so the change is invisible to debug logging, 2) normalizing some literals that should manage their own round-trip serialization

…xpression tree in place so the change is invisible to debug logging, 2) normalizing some literals that should manage their own round-trip serialization
@zachmu zachmu requested a review from Hydrocharged January 22, 2025 23:19
Copy link
Contributor

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zachmu zachmu merged commit 97b350e into main Jan 23, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants