Improve batch insertion for entities with auto-increment primary keys. #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retrieve primary keys using `Statement.getGeneratedKeys()` after executing `Statement.executeBatch()`, if supported by the DBMS.
|
This pull request makes it possible to batch process operations with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR retrieves primary keys using
Statement.getGeneratedKeys()after executingStatement.executeBatch(), if supported by the DBMS.Supported DBMS are as follows:
Oracle Database and SQL Server do not support the combination of
Statement.getGeneratedKeys()andStatement.executeBatch(). Therefore, Doma falls back to a process that repeatedly usesStatement.executeUpdate()for each entity in the batch.Previously, to speed up batch insertion in PostgreSQL, we used
org.seasar.doma.jdbc.id.IdProviderto retrieve IDs from the database in advance. However, since this pull request provides an alternative solution,org.seasar.doma.jdbc.id.IdProvideris now deprecated.