Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for <ineritdoc cref="" /> #2687

Closed
wants to merge 4 commits into from

Conversation

codecooper
Copy link

In answer to Issue #2597, this will recursively scan the XML documentation to gather the first property/attribute that contains the needed value. This change would work automatically without the user having to do anything extra.

Jason Cooper added 4 commits July 30, 2023 10:20
…cursively using the `inheritdoc` as a reference. Point all XPath queries to this class. Simplify some of the (if) nesting in the XML Comment Filters. Add unit tests for the new InheritDoc updates. some existing tests were converted from `Fact` to `Theory` to accomplish this.
@soroshsabz
Copy link

ITNOA

I need this feature too

@soroshsabz
Copy link

@codecooper please request this PR to https://github.com/Havunen/DotSwashbuckle

@martincostello
Copy link
Collaborator

Thanks for contributing - if you'd like to continue with this pull request, please rebase against the default branch to pick up our new CI.

@soroshsabz
Copy link

@codecooper Do you have any time to rebase this PR?

@soroshsabz
Copy link

@martincostello What is policy to How much waiting for PR owner to make PR ready for merging? in another word when we can create another PR for this feature?

@codecooper
Copy link
Author

I have just started on the rebase. It should be done this week as time permits.

Copy link
Contributor

This pull request is stale because it has been open for 60 days with no activity. It will be automatically closed in 14 days if no further changes are made.

@github-actions github-actions bot added the stale Stale issues or pull requests label Jul 19, 2024
Copy link
Contributor

github-actions bot commented Aug 3, 2024

This pull request was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this Aug 3, 2024
@soroshsabz
Copy link

@martincostello please reopen PR

thanks

@martincostello
Copy link
Collaborator

Even if I re-open it, it still needs rebasing. If the original contributor wishes to come back to this work, then can do so as a new PR.

@soroshsabz
Copy link

Finally, PR #3016 replaces this PR

thanks @codecooper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale issues or pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants