Fix Dotenv::Railtie.overload to keep .env files priority policy

bkeepers#424
domcermak · Jun 25, 2022 · fcdeac4 · fcdeac4
1 parent 9e101a5
commit fcdeac4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/dotenv/rails.rb b/lib/dotenv/rails.rb
@@ -45,7 +45,7 @@ def load
     #
     # Same as `load`, but will override existing values in `ENV`
     def overload
-      Dotenv.overload(*dotenv_files)
+      Dotenv.overload(*dotenv_files.reverse)
     end
 
     # Internal: `Rails.root` is nil in Rails 4.1 before the application is

diff --git a/spec/dotenv/rails_spec.rb b/spec/dotenv/rails_spec.rb
@@ -113,8 +113,8 @@ def add(*items)
       )
     end
 
-    it "overloads .env.test with .env" do
-      expect(ENV["DOTENV"]).to eql("true")
+    it "overloads .env with .env.test" do
+      expect(ENV["DOTENV"]).to eql("test")
     end
 
     context "when loading a file containing already set variables" do
@@ -125,7 +125,7 @@ def add(*items)
 
         expect do
           subject
-        end.to(change { ENV["DOTENV"] }.from("predefined").to("true"))
+        end.to(change { ENV["DOTENV"] }.from("predefined").to("test"))
       end
     end
   end