Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support .any.js tests #11

Closed
domenic opened this issue Nov 6, 2018 · 1 comment · Fixed by #12
Closed

Support .any.js tests #11

domenic opened this issue Nov 6, 2018 · 1 comment · Fixed by #12

Comments

@domenic
Copy link
Owner

domenic commented Nov 6, 2018

... and ideally then port the streams tests to .any.js format, removing their custom-generated wrappers

The easiest way to do this is probably to copy the logic from https://github.com/web-platform-tests/wpt/blob/24373750793a107c28dbfde50d61cfae192fb485/tools/serve/serve.py#L219 into this project.

/cc @MattiasBuelens

Forked from nodejs/whatwg-stream#1 (comment)
@MattiasBuelens MattiasBuelens mentioned this issue Nov 11, 2018
Merged
domenic pushed a commit that referenced this issue Nov 21, 2018
@MattiasBuelens @domenic
Support .any.js and .window.js tests
1d18a28 
This adds support for running tests with auto-generated test boilerplate (https://web-platform-tests.org/writing-tests/testharness.html#auto-generated-test-boilerplate), i.e. .any.js and .window.js tests. (Worker tests are ignored since jsdom doesn't support workers yet.)

This keeps the JavaScript implementation as close as possible to the original Python implementation from web-platform-tests (https://github.com/web-platform-tests/wpt/blob/926d722bfc83f3135aab36fddc977de82ed7e63e/tools/serve/serve.py). This should (hopefully) make maintaining our implementation a bit easier, in the (rare) case the test format changes in the future.

As part of this, we started using Node's new URL parser, bringing up our minimum version requirement.

Closes #11.
@MattiasBuelens
Copy link
Contributor

PR for porting the streams tests: web-platform-tests/wpt#14172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support .any.js and .window.js tests MattiasBuelens/wpt-runner
2 participants
@domenic @MattiasBuelens