Skip to content

Commit

Permalink
Dispose of TextEditingController in firebase-get-to-know-flutter (flu…
Browse files Browse the repository at this point in the history
…tter#2256)

Fixes [#115693 in
flutter/flutter](flutter/flutter#115693)
  • Loading branch information
ericwindmill authored Nov 5, 2024
1 parent 3920ded commit e438857
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 0 deletions.
6 changes: 6 additions & 0 deletions firebase-get-to-know-flutter/codelab_rebuild.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2166,6 +2166,12 @@ steps:
),
);
}
@override
void dispose() {
_controller.dispose();
super.dispose();
}
}
- name: Patch lib/home_page.dart
path: gtk_flutter/lib/home_page.dart
Expand Down
6 changes: 6 additions & 0 deletions firebase-get-to-know-flutter/step_06/lib/guest_book.dart
Original file line number Diff line number Diff line change
Expand Up @@ -64,4 +64,10 @@ class _GuestBookState extends State<GuestBook> {
),
);
}

@override
void dispose() {
_controller.dispose();
super.dispose();
}
}
6 changes: 6 additions & 0 deletions firebase-get-to-know-flutter/step_07/lib/guest_book.dart
Original file line number Diff line number Diff line change
Expand Up @@ -79,4 +79,10 @@ class _GuestBookState extends State<GuestBook> {
],
);
}

@override
void dispose() {
_controller.dispose();
super.dispose();
}
}
6 changes: 6 additions & 0 deletions firebase-get-to-know-flutter/step_09/lib/guest_book.dart
Original file line number Diff line number Diff line change
Expand Up @@ -79,4 +79,10 @@ class _GuestBookState extends State<GuestBook> {
],
);
}

@override
void dispose() {
_controller.dispose();
super.dispose();
}
}

0 comments on commit e438857

Please sign in to comment.