-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Distinguish between monitors of the same model #81
Comments
Hey @aidanlw505 thank you for sharing the issue and a possible solution! I agree with you. This will be fixed in the way you suggested by the next update |
@domferr I would like to try to implement that. |
Hey @milhauzindahauz that's great! The code to be changed is only in the file defaultMenu.ts. At line 172 there is the function
where
Please feel free to ask any question! I'm more than happy to provide any help 😄 Side notes:
|
Thank for the guidance. But I got to the correct place by myself with the same idea. I found out that on X11 server names are null. I am trying to figure out how to obtain details on X11. Further more: tilingshell/src/indicator/defaultMenu.ts Lines 82 to 90 in 5e85576
This method will update all monitors with same details of Monitor 1. Or am I missing anything? |
That's awesome!
Oh no, I didn't know that! Thank you!
The DefaultMenu shows one LayoutsRow for each monitor (and it stores them into this._layoutsRows). For each monitor I'm not sure this answer to your question, let me know otherwise! |
This make sense. You are updating in by the details of the subprocess result. But lets have the situation as described above. @aidanlw505 has three monitors with same resolutions. If I would got array of the details for that I got three items in array and their resolutions are the same. And after that I try updateMonitorName by finding the same resolution three times. I should stop the finding on the first match that means first item with same resolution in the array => same detail (item at index 0) for all of them. |
FWIW, the numbers attributed by GNOME to my monitors are not fixed at all 😅 I have 2 external screens, and they get numbers 2 and 3 interchangeably, each time I (un)plug my laptop. It's probably fair to say that I should not be the only one experiencing this issue so, what do you think of the following addition?
That way, no matter the names/numbers are, you directly see where the layout is supposed to be used. |
Yeah, I agree! I'd make the changes into the function
I'm happy to know your thoughts about it! Feel free to implement any other idea or this one, as you prefer. I don't think we should care too much about time complexity because the monitors are going to be 2 or 3, at most 4 or 5 for very lucky people ahaha |
Hey @GuillaumeAmat, that's annoying ahaha 😢 The idea you are sharing is good imho. I would still keep a different name (something like LG Electronics 34" 1, LG Electronics 34" 2) for people who want to know as quick as possible which monitor that row is referring to. |
Sure! That was just a suggestion to be added on top of what you already planned 🙏 |
Describe the feature you'd like
Currently, if all of your monitors are of the same model, they have the exact same name. This makes it hard to know which one you're changing the layout for.
I think taking the monitor's number that's shown in display settings and including it in the title would be really helpful.
The text was updated successfully, but these errors were encountered: