Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When given illegal arguments, a String is thrown, not an exception #89

Closed
vlovich opened this issue Feb 12, 2023 · 2 comments
Closed

When given illegal arguments, a String is thrown, not an exception #89

vlovich opened this issue Feb 12, 2023 · 2 comments

Comments

@vlovich
Copy link
Contributor

vlovich commented Feb 12, 2023

This results in an opaque stack trace:

Thrown at:
    at loadESM (node:internal/process/esm_loader:79:31)

The problematic line is 383:

    cb(
      stderr || err,

A simple fix would be to add a preceding line:

    if (stderr) { stderr = new Error(stderr) }
    cb(
      stderr || err,
@hipstersmoothie
Copy link
Collaborator

PRs welcome!

@vlovich vlovich mentioned this issue May 16, 2023
Merged
3 tasks
@vlovich
Copy link
Contributor Author

vlovich commented May 16, 2023

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vlovich @domharrington @hipstersmoothie