Make sure that errors throw Error instead of string #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventionally, thrown exceptions are Error objects instead of strings so that they can capture the stack of where the exception was generated from.
|
This resolves #89 |
|
Marking as major since this could break usage |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conventionally, thrown exceptions are Error objects instead of strings so that they can capture the stack of where the exception was generated from.
What's Changing
Change Type
Indicate the type of change your pull request is:
patchminormajorI think it's a patch but it is technically a change in the kind of error thrown so could be minor/major? Not sure. I'd like to keep it a patch so if this isn't acceptable I can retrofit an option to change this behavior.
Release Notes
This release fixes how this library throws errors. Instead of throwing
stringit will throw an actual error. Implementations might need updating.