Merge pull request #92 from vlovich/throw-error-instead-of-string

Make sure that errors throw Error instead of string
domharrington · May 16, 2023 · 7ae02f8 · 7ae02f8
2 parents 617373e + ddcafc3
commit 7ae02f8
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -380,10 +380,11 @@ function gitlog<Field extends CommitField = DefaultField>(
 
     debug("commits", commits);
 
-    cb(
-      stderr || err,
-      parseCommits(commits, options.fields, options.nameStatus)
-    );
+    if (stderr) {
+      err = new Error(stderr);
+    }
+
+    cb(err, parseCommits(commits, options.fields, options.nameStatus));
   });
 }
 

diff --git a/test/gitlog.test.ts b/test/gitlog.test.ts
@@ -36,6 +36,12 @@ describe("gitlog", () => {
     );
   });
 
+  it("throws an error when bad option - promise", async () => {
+    await expect(
+      gitlogPromise({ repo: testRepoLocation, branch: "not-a-branch" })
+    ).rejects.toBeInstanceOf(Error);
+  });
+
   it("returns 21 commits from specified branch", (done) => {
     gitlog(
       { repo: testRepoLocation, branch: "new-branch", number: 100 },