Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs updating to support videojs 5.0 #36

Open
paladox opened this issue Sep 16, 2015 · 8 comments
Open

Needs updating to support videojs 5.0 #36

paladox opened this issue Sep 16, 2015 · 8 comments

Comments

@paladox
Copy link

paladox commented Sep 16, 2015

Hi this needs updating to support videojs 5.0.

@dominic-p
Copy link
Owner

It sure does. Pull requests welcome. :)

@paladox
Copy link
Author

paladox commented Sep 16, 2015

Well there are some fixes here https://git.wikimedia.org/raw/mediawiki%2Fextensions%2FTimedMediaHandler/ae23f54bfa559b5846b4e0f213e89c6250687370/resources%2Fvideojs-resolution-selector%2Fvideo-quality-selector.js but my edit should be changed back to original since they are Wikimedia specific.

@dominic-p
Copy link
Owner

Thanks for that file. It will certainly help when I get around to working on 5.0 compatibility. Out of curiosity, is Wikimedia using Video.js with this plugin as their video player?

@paladox
Copy link
Author

paladox commented Sep 16, 2015

Currently wikimedia are currently deciding to choose a different video player and choose video.js to try. And yes the plugin was updated manually by another user working on the patch.

@paladox paladox changed the title Nees updating to support videojs 5.0 Needs updating to support videojs 5.0 Oct 2, 2015
@paladox
Copy link
Author

paladox commented Oct 2, 2015

videojs 5.0 has been released.

paladox added a commit to paladox/videojs-resolution-selector that referenced this issue Oct 2, 2015
@dominic-p
Copy link
Owner

Just wanted to let you know I saw the pull request. Life has been pretty hectic for me, so I haven't had a chance to look at it yet. One concern I have is that it looks like it breaks compatibility with Video.js 4.x.

Do you know if it could be tweaked to work with both?

@paladox
Copy link
Author

paladox commented Oct 5, 2015

I doint think so but maybe you can create a branch for vjs 4.0 compat and use master to stay compat with latest vjs release.

@RomanEmelyanov
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants