🛠 Refactor: RNIPopoverViewModule.getVisibility Error Handling

dominicstop · Aug 30, 2022 · 2385908 · 2385908
1 parent 79001a5
commit 2385908
Showing 1 changed file with 4 additions and 14 deletions.
diff --git a/ios/Src/RNIPopoverViewModule/RNIPopoverViewModule.swift b/ios/Src/RNIPopoverViewModule/RNIPopoverViewModule.swift
@@ -84,20 +84,10 @@ class RNIPopoverViewModule: NSObject {
   ) {
 
     DispatchQueue.main.async {
-      guard let bridge = self.bridge,
-            let view   = bridge.uiManager?.view(forReactTag: node),
-            let popoverView = view as? RNIPopoverView
-      else {
-        let errorMessage = (
-            "RNIPopoverViewModule: getVisibility()"
-          + " - guard check failed"
-          + " - could not get `popoverView` instance"
-        );
-
-        // code, message, error
-        reject("LIB_ERROR", errorMessage, nil);
-        return;
-      };
+      let errorPrefix = "RNIPopoverViewModule: getVisibility()";
+
+      guard let (_, popoverView) = self.getInstance(node, errorPrefix, reject)
+      else { return };
 
       #if DEBUG
       print("RNIPopoverViewModule, getVisibility: \(popoverView.isPopoverVisible)");