cleanup duplicate code for list records function #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikbraun
approved these changes
Jul 11, 2021
|
You're Welcome!! Thank you for letting me pick this up and contribute. What does the merge process look like? Will you do it? |
|
Yes, I'm going to merge this probably later today. I've got quite some issues and PRs open and want to make sure only specific ones go into the following 0.12.0 release. This one will definitely included in 0.12.0. |
|
sounds good. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core/record.go#163, changingListRecordsto call the functionloadAllRecordsas the implementation is the same.Issue: #163