-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scan test #89
Scan test #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found no errors, ready to merge from my side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a small bug that would raise an error when calculating structure factors for models with multiple structure factor components.
Co-authored-by: Lasse Gresista <37416918+lgresista@users.noreply.github.com>
Co-authored-by: Lasse Gresista <37416918+lgresista@users.noreply.github.com>
Committed your suggestion, bug should be fixed. |
Improved scanning routine and fixed some minor bugs. In some cases, redundant arguments were removed. Further solver optimizations were added.