Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan test #89

Merged
merged 28 commits into from
Dec 7, 2023
Merged

Scan test #89

merged 28 commits into from
Dec 7, 2023

Conversation

dominikkiese
Copy link
Owner

Improved scanning routine and fixed some minor bugs. In some cases, redundant arguments were removed. Further solver optimizations were added.

Copy link
Collaborator

@lgresista lgresista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found no errors, ready to merge from my side.

Copy link
Collaborator

@lgresista lgresista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a small bug that would raise an error when calculating structure factors for models with multiple structure factor components.

src/Observable/disk.jl Outdated Show resolved Hide resolved
src/Observable/disk.jl Outdated Show resolved Hide resolved
dominikkiese and others added 2 commits March 9, 2022 16:44
Co-authored-by: Lasse Gresista <37416918+lgresista@users.noreply.github.com>
Co-authored-by: Lasse Gresista <37416918+lgresista@users.noreply.github.com>
@dominikkiese
Copy link
Owner Author

Committed your suggestion, bug should be fixed.

@dominikkiese dominikkiese merged commit ad5bb49 into main Dec 7, 2023
@dominikkiese dominikkiese deleted the scan_test branch December 7, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants