Removes server name checking from secret-based registry auth #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user wants to authenticate with 2 or more registries contained within a single k8s secret, then they are required to create an
ImageBuild
with the following auth section:and this can become somewhat cumbersome as that list grows. Furthermore, the
server
field for secrets is meant to server as a verification mechanism (i.e. an error will be raised if it's missing from the underlying secret data). I think we can add the verification to another field, or implement a different way that removes the labor involved here. For now, I'm disabling it and promoting all auths contained within the secret over to buildkit.Tested locally pulling from one private registry and pushing to a different private registry with a single secret containing both sets of credentials.
/cc @ddl-kevin