Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generated example output #97

Merged
merged 6 commits into from
Dec 6, 2022
Merged

Fix generated example output #97

merged 6 commits into from
Dec 6, 2022

Conversation

domjtalbot
Copy link
Owner

@domjtalbot domjtalbot commented Dec 6, 2022

What's Changed?

Fix the generated source files for:

  • country-info
  • fake-api
  • javascript-wiki
  • movies
  • rfam
  • stackexchange
  • star-wars-api
  • trippin

Test all generator examples in GitHub Actions and confirm they can build successfully.

@nx-cloud
Copy link

nx-cloud bot commented Dec 6, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b0525b2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 45 targets

Sent with 💌 from NxCloud.

@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2022

🦋 Changeset detected

Latest commit: b0525b2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
nx-mesh Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -111,4 +111,92 @@ describe('createSharedFiles', () => {
});
});
});

describe('movies', () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 5 locations. Consider refactoring.

});
});

describe('rfam', () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 5 locations. Consider refactoring.

});
});

describe('star-wars-api', () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 5 locations. Consider refactoring.

});
});

describe('trippin', () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 5 locations. Consider refactoring.

@domjtalbot domjtalbot changed the title Fix/generated examples Fix generated example output Dec 6, 2022
@github-actions github-actions bot temporarily deployed to nextjs Preview December 6, 2022 21:56 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
nx-mesh 2.0.1-alpha-20221206220521 npm ↗︎ unpkg ↗︎

@github-actions github-actions bot added the vercel An issue or pull request related to Vercel label Dec 6, 2022
@codeclimate
Copy link

codeclimate bot commented Dec 6, 2022

Code Climate has analyzed commit b0525b2 and detected 5 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 5

View more on Code Climate.

@github-actions github-actions bot temporarily deployed to nextjs Preview December 6, 2022 22:04 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

This pull request has been deployed to Vercel.

Latest commit: b0525b2
✅ Preview: https://nx-mesh-4bi5l4d2y-domjtalbot.vercel.app
🔍 Inspect: https://vercel.com/domjtalbot/nx-mesh/5oZK6vsh8EaU3WCSDoUD74kKT1Pp

View Workflow Logs

@sonarcloud
Copy link

sonarcloud bot commented Dec 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@domjtalbot domjtalbot marked this pull request as ready for review December 6, 2022 22:10
@domjtalbot domjtalbot self-assigned this Dec 6, 2022
@domjtalbot domjtalbot merged commit fd8de91 into main Dec 6, 2022
@domjtalbot domjtalbot deleted the fix/generated-examples branch December 6, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vercel An issue or pull request related to Vercel
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant