Fixed peer status is not refreshing correctly #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
donaldzou
commented
Aug 18, 2024
donaldzou
commented
- Peer was not refreshing correctly.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| p[pCounter]["name"] = split[1] | ||
| # if self.__configFileModifiedTime is None or self.__configFileModifiedTime != mt: | ||
| self.Peers = [] | ||
| with open(os.path.join(WG_CONF_PATH, f'{self.Name}.conf'), 'r') as configFile: |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
|
|
||
| for i in p: | ||
| if "PublicKey" in i.keys(): | ||
| checkIfExist = sqldb.cursor().execute("SELECT * FROM '%s' WHERE id = ?" % self.Name, |
Check failure
Code scanning / CodeQL
SQL query built from user-controlled sources High
Comment on lines
+629
to
+634
| """ | ||
| INSERT INTO '%s' | ||
| VALUES (:id, :private_key, :DNS, :endpoint_allowed_ip, :name, :total_receive, :total_sent, | ||
| :total_data, :endpoint, :status, :latest_handshake, :allowed_ip, :cumu_receive, :cumu_sent, | ||
| :cumu_data, :mtu, :keepalive, :remote_endpoint, :preshared_key); | ||
| """ % self.Name |
Check failure
Code scanning / CodeQL
SQL query built from user-controlled sources High
| sqldb.commit() | ||
| self.Peers.append(Peer(newPeer, self)) | ||
| else: | ||
| sqldb.cursor().execute("UPDATE '%s' SET allowed_ip = ? WHERE id = ?" % self.Name, |
Check failure
Code scanning / CodeQL
SQL query built from user-controlled sources High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.