Generated app not starting with node@7.6.0 and npm@5.0.3

[marshallswain]

How often can you reproduce it?

• Always
• Sometimes
• Rarely
• Unable
• I didn’t try

After creating an application with donejs add app pwa-test, when I open the root directory and run donejs develop, I get the following error:

I see that done-serve is in the package.json dependencies, but it's not getting installed into node_modules/.bin:

Maybe this is an npm bug. I'm using npm@5.0.3 with node@7.6.0.

Steps to reproduce:

• npm install -g npm donejs
• donejs add app pwa-test
• cd-pwa-test
• donejs develop

Expected results:

The app should start without a problem.

Actual results:

The above error is thrown.

Environment:

Software	Version
donejs -V	1.0.0
node -v	7.6.0
npm -v	5.0.3
Operating system	macOS 10.12.5

[marshallswain]

However, if I delete the node_modules folder and the package.lock.json and npm install again, it works as expected.

[phillipskevin]

@obaidott can you look into this while you're working on adding Node 8 to CI?

[matthewp]

My guess is that the way donejs add app works is that the new lockfile gets created prevents additional packages from being installed. We might want to use the flag to disable the lockfile (if that is indeed the problem, just a guess here).

[frank-dspeed]

@matthewp this can be closed can't reproduce error. donejs add app + donejs develop works under node 7.6 even under node 8.1.2

[matthewp]

Thanks.

[chasenlehara]

This is still an issue. I just tested with npm 5.0.3 & Node 8.1.2 and I got the same issues as what @marshallswain originally reported.

[marshallswain]

Looks like others are having this same issue, related to package.lock.json: https://codeburst.io/disabling-package-lock-json-6be662f5b97d

It might be a quick easy fix to use --no-package-lock during the first npm install at

donejs/lib/cli/cmd-init.js

Lines 29 to 34 in 85650e5

	// install donejs-cli
	function installCli(version, options) {
	var pkg = 'donejs-cli@' + utils.versionRange(version);
	var npmArgs = [ 'install', pkg, '--loglevel', 'error' ];
	return utils.spawn('npm', npmArgs, options);
	}

[frank-dspeed]

@chasenlehara why do i not get that error? maybe because using yarn right?

[chasenlehara]

Probably! The original issue makes it pretty clear that npm was being used. Please don’t leave comments saying issues are fixed if you haven’t reproduced the original issue and can confirm it was fixed. 😊

[frank-dspeed]

@chasenlehara i reproduced it i runned a donejs app a fresh one under node 7.6 and 8.1 but i am using docker that means i mount the project dir and then on startup use yarn :)

[andrejewski]

This has been solved. It took making changes to both donejs/donejs and donejs/cli, but now neither step will create a package-lock.json file. In order to close this issue, a donejs/donejs patch release will have to be made with @chasenlehara's #978 changes, the donejs/cli changes are in its v1.0.2.

[frank-dspeed]

@andrejewski so you mean

npm install -g donejs@^1.0.1

[andrejewski]

@frank-dspeed No, the fix for donejs will be released as DoneJS v1.0.1. At which point people can update using npm install -g donejs and this issue can be closed.