Skip to content

Commit

Permalink
[SPARK-45021][BUILD] Remove antlr4-maven-plugin configuration from …
Browse files Browse the repository at this point in the history
…`sql/catalyst/pom.xml`

### What changes were proposed in this pull request?
SPARK-44475(apache#41928) has already moved the `antlr4-maven-plugin` relevant configuration to `sql/api/pom.xml`, so the configuration in the `catalyst` module is unused now, so this pr remove it from `sql/catalyst/pom.xml`

### Why are the changes needed?
Clean up unused Maven `antlr4-maven-plugin` from catalyst module.

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
- Pass GitHub Actions
- Manual verification

```
build/mvn clean install -DskipTests -pl sql/catalyst -am
```

Before

We can see

```
[INFO]
[INFO] --- antlr4-maven-plugin:4.9.3:antlr4 (default)  spark-catalyst_2.12 ---
[INFO] No ANTLR 4 grammars to compile in /Users/yangjie01/SourceCode/git/spark-mine-12/sql/catalyst/src/main/antlr4
[INFO]
```

After

no relevant messages.

### Was this patch authored or co-authored using generative AI tooling?
No

Closes apache#42739 from LuciferYang/remove-antlr4-catalyst.

Authored-by: yangjie01 <yangjie01@baidu.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
  • Loading branch information
LuciferYang authored and dongjoon-hyun committed Aug 30, 2023
1 parent edd2106 commit 5df4e16
Showing 1 changed file with 0 additions and 16 deletions.
16 changes: 0 additions & 16 deletions sql/catalyst/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -154,22 +154,6 @@
<argLine>-ea -Xmx4g -Xss4m -XX:ReservedCodeCacheSize=${CodeCacheSize} ${extraJavaTestArgs} -Dio.netty.tryReflectionSetAccessible=true</argLine>
</configuration>
</plugin>
<plugin>
<groupId>org.antlr</groupId>
<artifactId>antlr4-maven-plugin</artifactId>
<executions>
<execution>
<goals>
<goal>antlr4</goal>
</goals>
</execution>
</executions>
<configuration>
<visitor>true</visitor>
<sourceDirectory>../catalyst/src/main/antlr4</sourceDirectory>
<treatWarningsAsErrors>true</treatWarningsAsErrors>
</configuration>
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>build-helper-maven-plugin</artifactId>
Expand Down

0 comments on commit 5df4e16

Please sign in to comment.