Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vuex, 404 and non auth navbar #35

Merged
merged 7 commits into from
Jun 20, 2021
Merged

Add vuex, 404 and non auth navbar #35

merged 7 commits into from
Jun 20, 2021

Conversation

ya7on
Copy link
Member

@ya7on ya7on commented Jun 13, 2021

No description provided.

@ya7on ya7on requested a review from tmcgroul June 13, 2021 21:23
@ya7on ya7on enabled auto-merge (squash) June 13, 2021 21:26
@tmcgroul
Copy link
Member

@BehindLoader a u tebya takoy owibki ne bilo?

ERROR in src/components/NotFound.vue:34:19
TS2339: Property 'icons' does not exist on type 'ComponentPublicInstance<{}, {}, {}, {}, {}, EmitsOptions, {}, {}, false, ComponentOptionsBase<{}, {}, {}, {}, {}, ComponentOptionsMixin, ComponentOptionsMixin, EmitsOptions, string, {}>>'.
    32 |   computed: {
    33 |     currentIcon() {
  > 34 |       return this.icons[this.iconIndex]
       |                   ^^^^^
    35 |     }
    36 |   },
    37 |   created() {

ERROR in src/components/NotFound.vue:34:30
TS2339: Property 'iconIndex' does not exist on type 'ComponentPublicInstance<{}, {}, {}, {}, {}, EmitsOptions, {}, {}, false, ComponentOptionsBase<{}, {}, {}, {}, {}, ComponentOptionsMixin, ComponentOptionsMixin, EmitsOptions, string, {}>>'.
    32 |   computed: {
    33 |     currentIcon() {
  > 34 |       return this.icons[this.iconIndex]
       |                              ^^^^^^^^^
    35 |     }
    36 |   },
    37 |   created() {
    ```

@ya7on
Copy link
Member Author

ya7on commented Jun 14, 2021

@tmcgroul очень странно. я тип добавил, вроде пропало

src/App.vue Outdated
@@ -1,3 +1,19 @@
<template>
<navbar @create-server="servers.push($event)" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vot tut owibka
i ne ochevidno kak ee ispravit'....

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nu mojno poka ob'yavit' servers v App.vue i propsami kidat' v dashboard

@ya7on ya7on requested a review from tmcgroul June 20, 2021 18:28
@ya7on ya7on changed the title Add 404 and update navbar Add vuex, 404 and non auth navbar Jun 20, 2021
@ya7on ya7on disabled auto-merge June 20, 2021 18:28
@ya7on ya7on enabled auto-merge (squash) June 20, 2021 18:29
src/store.ts Outdated
id: number,
username: string,
}

interface Server {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В interfaces.ts есть нужный интерфейс

@ya7on ya7on merged commit 94b49f1 into master Jun 20, 2021
@ya7on ya7on deleted the navbar-and-404 branch June 20, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants