Implement WebSocket #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmcgroul
requested changes
Jul 11, 2021
src/websocket.ts
Outdated
| data: any, | ||
| } | ||
|
|
||
| export type EventTypes = 'LOGS' | 'SERVERS' |
There was a problem hiding this comment.
может лучше enum тут использовать?
src/pages/Dashboard/ServerItem.vue
Outdated
| // TODO https://github.com/donkey-engine/donkey-engine-ui/issues/45 | ||
|
|
||
| const wsClient = getClient() | ||
| wsClient.on('SERVERS', (data) => { |
There was a problem hiding this comment.
а если 2 раза поменять статус, то в eventHandlers будет 2 колбэка на любое изменение в серверах?
а если у нас уничтожится компонент и коллбэк попробует поменять у него this.pending?
tmcgroul
requested changes
Jul 20, 2021
| @@ -137,18 +138,19 @@ export default defineComponent({ | |||
| } | |||
| } | |||
| }, | |||
| created() { | |||
| const wsClient = getClient() | |||
| wsClient.on(EventTypes.SERVERS, (data) => { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.