Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update builds for microbundle v15 #619

Merged
merged 1 commit into from
Jul 10, 2022
Merged

Update builds for microbundle v15 #619

merged 1 commit into from
Jul 10, 2022

Conversation

donmccurdy
Copy link
Owner

@donmccurdy donmccurdy added bug Something isn't working package:core labels Jul 10, 2022
@donmccurdy donmccurdy mentioned this pull request Jul 10, 2022
Closed
@donmccurdy
Copy link
Owner Author

Root cause of #611, as far as I can tell:

  1. the update to microbundle v15 changed default output to .mjs
  2. builds did not include a step to clean the output folder, so old .js files remained
  3. tests resolved new files locally (somehow? different bundler?) but some bundlers resolved to the old files, mismatched to dependencies, and hit errors.

@donmccurdy donmccurdy merged commit 9f63beb into main Jul 10, 2022
@donmccurdy donmccurdy deleted the hotfix/microbundle-v15 branch July 10, 2022 22:56
@donmccurdy donmccurdy mentioned this pull request Jul 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working package:core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@gltf-transform/extensions: 'KTX2Model' was not found in 'ktx-parse'
1 participant
@donmccurdy