Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

headerText property doesn't change the header #94

Closed
emersonsiega opened this issue Mar 26, 2019 · 1 comment · Fixed by #144
Closed

headerText property doesn't change the header #94

emersonsiega opened this issue Mar 26, 2019 · 1 comment · Fixed by #144
Labels
bug Something isn't working

Comments

@emersonsiega
Copy link

Version of flutter_calendar_carousel

1.3.15+

Expected behavior

headerText: Text(DateFormat('MMMM').format(_date))

Actual behavior

Always show the default header.

flutter doctor result (run flutter doctor in terminal)

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, v1.2.1, on Mac OS X 10.14.3 18D109, locale pt-BR)
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
[✓] Android Studio (version 3.3)
[✓] Connected device (2 available)

• No issues found!

Steps to reproduce the behavior

Just instantiate a CalendarCarousel with headerText property defined.

CalendarCarousel(
    height: calendarHeight,
    locale: "pt-BR",
    headerText: Text(DateFormat('MMMM').format(_date)),
    selectedDateTime: _date,
)
@hyochan hyochan added the bug Something isn't working label Mar 29, 2019
hyochan added a commit that referenced this issue Sep 14, 2019
@hyochan
Fixes #94
55bf60a
hyochan added a commit that referenced this issue Sep 14, 2019
@hyochan
Fixes #94
1cde9f3
@hyochan
Copy link
Owner

hyochan commented Sep 14, 2019

Will be fixed in 1.3.23.

@hyochan hyochan mentioned this issue Sep 14, 2019
Merged
hyochan added a commit that referenced this issue Sep 14, 2019
@hyochan
Release/1.3.23 (#144)
b0a30ff 
* Add feature on customizing markedDates text and decoration
   - More code formattings.
* Add markedDateCustomShapeBorder.
* Add markedDateCustomTextstyle.
* Add documentation on newly added parameters
* Update readme.
* Support customization on each event dot widget
   - Fixes #112.
* Give inactiveDaysTextStyle prior to other text styles
   - Fixes #101
* Fixed selectedDayTextStyle overriden by todayTextStyle
   - Fixes #101.
   - Make `renderDay` and `getDefaultTextStyle` to organize week calendar and month calendar properties into one.
* Support onDayLongPressed as a feature request
   - Fixes #103.
* Support semantic label
   - Fixes #139
* Expose `dayCrossAxisAlignment` and `dayMainAxisAlignment` to resolve #122
* Expose `showIconBehindDayText` to resolve #131 
* Fixes #94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release/1.3.23 hyochan/flutter_calendar_carousel
2 participants
@emersonsiega @hyochan