Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inactiveDaysTextStyle and inactiveWeekendTextStyle are overridden by prevDaysTextStyle and nextDaysTextStyle #101

Closed
nohli opened this issue Apr 28, 2019 · 3 comments · Fixed by #144
Labels
bug Something isn't working

Comments

@nohli
Copy link
Contributor

nohli commented Apr 28, 2019

Version of flutter_calendar_carousel

1.3.16

Expected behavior

Inactive calendar items all have the same color

Actual behavior

inactiveDaysTextStyle and inactiveWeekendTextStyle are overridden by prevDaysTextStyle and nextDaysTextStyle

flutter doctor result (run flutter doctor in terminal)

Steps to reproduce the behavior

        minSelectedDate: DateTime.now(),
        inactiveDaysTextStyle: TextStyle(color: Colors.white24),
        nextDaysTextStyle: TextStyle(color: red),
@hyochan hyochan added the bug Something isn't working label May 5, 2019
@hyochan
Copy link
Owner

hyochan commented May 5, 2019

So it's a bug. We need to investigate this, but sorry that I am really busy these days. Hope I can comeback on this.

@nohli
Copy link
Contributor Author

nohli commented May 5, 2019

Okay, just wanted you to know. It's a great widget :-)

@Shakle
Copy link

Shakle commented Aug 8, 2019

Can someone please fix it?

hyochan added a commit that referenced this issue Sep 14, 2019
- Fixes #101.
- Make `renderDay` and `getDefaultTextStyle` to organize week calendar and month calendar properties into one.
@hyochan hyochan mentioned this issue Sep 14, 2019
hyochan added a commit that referenced this issue Sep 14, 2019
* Add feature on customizing markedDates text and decoration
   - More code formattings.
* Add markedDateCustomShapeBorder.
* Add markedDateCustomTextstyle.
* Add documentation on newly added parameters
* Update readme.
* Support customization on each event dot widget
   - Fixes #112.
* Give inactiveDaysTextStyle prior to other text styles
   - Fixes #101
* Fixed selectedDayTextStyle overriden by todayTextStyle
   - Fixes #101.
   - Make `renderDay` and `getDefaultTextStyle` to organize week calendar and month calendar properties into one.
* Support onDayLongPressed as a feature request
   - Fixes #103.
* Support semantic label
   - Fixes #139
* Expose `dayCrossAxisAlignment` and `dayMainAxisAlignment` to resolve #122
* Expose `showIconBehindDayText` to resolve #131 
* Fixes #94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants