Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support null safety #260

Closed
IchordeDionysos opened this issue Feb 23, 2021 · 4 comments · Fixed by #263 or #272
Closed

Support null safety #260

IchordeDionysos opened this issue Feb 23, 2021 · 4 comments · Fixed by #263 or #272

Comments

@IchordeDionysos
Copy link
Contributor

This is a request to add support for null safety to package:flutter_calendar_carousel.
We depend on your awesome package, so would be great to have null safety enabled.

The Dart/Flutter team already encourages publishing the migrated packages: See this blog post.

See the migration guide for details about enabling null safety.
@IchordeDionysos
Copy link
Contributor Author

IchordeDionysos commented Mar 3, 2021 •
edited
Loading

The new Dart version with null-safety was just released 😍
https://medium.com/dartlang/announcing-dart-2-12-499a6e689c87

@IchordeDionysos IchordeDionysos mentioned this issue Mar 6, 2021
Merged
@Zeswen
Copy link

Zeswen commented Mar 11, 2021

Waiting for this to update our application to Flutter 2.0!

It would be awesome to have it ASAP. Thank you for your great work :)

@IchordeDionysos
Copy link
Contributor Author

@Zeswen you can upgrade to Flutter 2.0 even with this package.

Flutter implemented null-safety in a backwards compatible manner 💪

But you might mean that you can't migrate your app to null-safety or switch to sound null-safety :)

@Zeswen
Copy link

Zeswen commented Mar 11, 2021

@Zeswen you can upgrade to Flutter 2.0 even with this package.

Flutter implemented null-safety in a backwards compatible manner 💪

But you might mean that you can't migrate your app to null-safety or switch to sound null-safety :)

Exactly! I'd love to switch to sound null-safety, looking forward to it 🚀

hyochan pushed a commit that referenced this issue Mar 17, 2021
@IchordeDionysos
Migrate to null-safety (#263)
6d2ddd8 
Migrates the package to support null-safety. 🚀 

Closes #260.
@trygvis trygvis mentioned this issue Mar 26, 2021
Closed
trygvis added a commit to trygvis/flutter_calendar_carousel that referenced this issue Apr 7, 2021
@trygvis
Null safety improvements
5a1acdb 
Allow customDayBuilder and markedDateIconBuilder to return null. If it
returns null, use the default. This restores the original behavior from
v1. Fixes hyochan#260.
@trygvis trygvis mentioned this issue Apr 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@IchordeDionysos @Zeswen