Migrate to null-safety #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+28
to
+29
| final customWeekdayBuilder = this.customWeekdayBuilder; | ||
| return customWeekdayBuilder != null |
There was a problem hiding this comment.
Why don't you just compare with this.customWeekdayBuilder;?
return this.customWeekdayBuilder != null
There was a problem hiding this comment.
@WilliamCunhaCardoso Looks like @IchordeDionysos didn't want to use this.customWeekdayBuilder twice in the below lines.
| width: markedDateMoreShowTotal ? 18 : null, | ||
| height: markedDateMoreShowTotal ? 18 : null, | ||
| decoration: markedDateMoreCustomDecoration == null | ||
| ? new BoxDecoration( |
There was a problem hiding this comment.
new cast is not necessary
Suggested change
| ? new BoxDecoration( | |
| ? BoxDecoration( |
There was a problem hiding this comment.
Since this is not a critical one, will be fine here.
|
Very nice work. Why does it still on draft? |
|
Does this PR also solves this? #250 |
|
It's been 10 days since the PR. Any news about this or sound null-safety? |
|
@IchordeDionysos Is this ready for review? |
|
@hyochan yes sorry :) |
hyochan
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates the package to support null-safety. 🚀
Closes #260.