Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support GFM alerts & render perf #446

Merged
merged 17 commits into from
Nov 22, 2024
Merged

Conversation

dribble-njr
Copy link
Member

@dribble-njr dribble-njr commented Nov 21, 2024

  • support GFM alerts
  • indent code block render abnomal (mac style or not both)
  • ensure proper Markdown parsing for link

before:

image

after:

image

Copy link

github-actions bot commented Nov 21, 2024

🎊 PR Preview has been successfully built and deployed to https://doocs-md-preview-pr-446.surge.sh

@dribble-njr dribble-njr changed the title feat: support GFM alerts & indent code block render pref feat: support GFM alerts & render pref Nov 21, 2024
@YangFong
Copy link
Member

Need to check preview:

image

@yanglbme
Copy link
Member

是的,无法正常预览

@dribble-njr
Copy link
Member Author

ok,我排查一下

@dribble-njr dribble-njr changed the title feat: support GFM alerts & render pref feat: support GFM alerts & render perf Nov 21, 2024
@dribble-njr
Copy link
Member Author

已修复

@YangFong
Copy link
Member

测试数据:

> [!NOTE]  
> Highlights information that users should take into account, even when skimming.

> [!TIP]
> Optional information to help a user be more successful.

> [!IMPORTANT]  
> Crucial information necessary for users to succeed.

> [!WARNING]  
> Critical content demanding immediate user attention due to potential risks.

> [!CAUTION]
> Negative potential consequences of an action.

编辑器可以正常保存并浏览,就是使用比较费劲,必须要全部大写,

在暗色模式下,会有所不搭:

image

这是在微信浏览中的默认表现,可以做一下暗色预览适配:

image

@dribble-njr
Copy link
Member Author

应该可以了,增加了预览的深色模式适配 & 大小写匹配

@yanglbme
Copy link
Member

image

全大写的情况下,渲染后的文本多了 [!IMPORTANT]

@dribble-njr
Copy link
Member Author

抱歉,漏改一个地方

@yanglbme
Copy link
Member

image

Caution 我看着不太对

src/assets/example/theme-css.txt Outdated Show resolved Hide resolved
@yanglbme
Copy link
Member

看着没啥问题了,准备合并,感谢你的贡献 @dribble-njr

@dribble-njr
Copy link
Member Author

稍等,我准备再做一点优化, @yanglbme 自定义 GFM 样式那块之前的写法有点小问题

@yanglbme
Copy link
Member

@dribble-njr
Copy link
Member Author

麻烦再看看,这次修复了之前 GFM 块不随字体样式改变的问题,并且优化了他的自定义样式

@yanglbme
Copy link
Member

可以

@yanglbme yanglbme merged commit d8b14f5 into doocs:main Nov 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants