Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grass Lighting adjustment #195

Closed
ikonomov opened this issue Feb 27, 2024 · 6 comments
Closed

Grass Lighting adjustment #195

ikonomov opened this issue Feb 27, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@ikonomov
Copy link

ikonomov commented Feb 27, 2024

If possible to do, please consider adding two additional sliders to control the amount of light that the grass receives, one slider for the environment (weather) lighting and other slider for other light sources such as torches, spells, braziers...

@alandtse
Copy link
Collaborator

This is going to be a larger discussion and probably won't move forward without a change in position. @doodlum is pushing against more options and advocating for mod authors to fix their assets instead.

@alandtse alandtse added the enhancement New feature or request label Feb 28, 2024
@alandtse
Copy link
Collaborator

See #184 for example.

@ikonomov
Copy link
Author

The issue I have is with vanilla grass. I can't get it to look good under various lighting conditions with the limited available settings under Grass Lighting.

@ikonomov
Copy link
Author

ikonomov commented Mar 1, 2024

Also grass textures cannot account for weather lighting changes. I think the example you gave of removing parallax height setting is not really a good comparison. We can be idealists and pretend that everything can be made to work out of the box, but many things can't and need further adjustment to be done on the other end.

@ikonomov
Copy link
Author

A third problem to consider is the use of grass billboards with DynDOLOD 3.0. The lighting in the loaded cell can create a big difference between loaded grass and grass billboards. This is a problem that is not specific to grass, but it is especially noticeable with grass. The ability to be able to control the strength of the light that hits the grass could greatly help reduce this issue to the point where it's not visible.

@ikonomov
Copy link
Author

ikonomov commented Mar 20, 2024

doodlum has graciously provided a solution to allow the grass to receive similar weather lighting as vanilla, making it possible to use CS Grass Lighting with the benefit of having other light sources to bounce off grass. I'm uploading the same file here in case somebody else wants to use it.
RunGrass.zip

Edit: This file is based on Grass Lighting v1.4.1. It would be nice if this ability can be added as a toggle.
Edit 2: After some further testing using this tweak I've found that the lighting on grass is still substantially different from vanilla as the weather light changes. However, it allows getting it a little closer in color and brightness to the lighting in vanilla, so it's still a really helpful addition in my opinion.

@ikonomov ikonomov reopened this Mar 20, 2024
@doodlum doodlum closed this as completed Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants