Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When the local user is speaking, increase face tracking send rate: #75

Draft
wants to merge 2 commits into
base: New-Server-Ready
Choose a base branch
from
Draft

When the local user is speaking, increase face tracking send rate: #75

wants to merge 2 commits into from

Conversation

hai-vr
Copy link
Contributor

@hai-vr hai-vr commented Dec 20, 2024

  • When the local user is speaking, increase the face tracking packet rate to 33 packets per second instead of 10 packets per second.
  • This is experimental to see if better mouth movements could be captured.

@hai-vr hai-vr marked this pull request as draft December 20, 2024 06:17
@hai-vr hai-vr force-pushed the voice-increases-face-tracking-rate branch 2 times, most recently from 609feec to b0df6d9 Compare December 20, 2024 08:08
@dooly123
Copy link
Owner

you should also look at grabbing the interval rate from the networked player's transmitter,

this will allow you to use the same interval or scaler rates to piggyback on the local transmit speed.

doing so would mean that you would only be sending decently fast data when there is someone nearby

@hai-vr hai-vr force-pushed the voice-increases-face-tracking-rate branch from b0df6d9 to 97d1e97 Compare December 20, 2024 09:13
@hai-vr
When the local user is speaking, increase face tracking send rate:
93ccf4c 
- When the local user is speaking, increase the face tracking packet rate to 33 packets per second instead of 10 packets per second.
- This is experimental to see if better mouth movements could be captured.
@hai-vr
Face tracking send rate now considers transmitter interval:
4d101c0 
- The transmission interval is now taken into consideration for transmission of packets.
- High speed transmission is now equal to the transmitter default interval constant, which is 30 packets per second.
- Regular speed transmission is still 10 packets per second.
- Maximum interval is set to the transmitter slowest send interval, even for regular speed transmission, which is currently 2.5 seconds.
@hai-vr hai-vr force-pushed the voice-increases-face-tracking-rate branch from 97d1e97 to 4d101c0 Compare December 21, 2024 17:39
@hai-vr
Copy link
Contributor Author

hai-vr commented Dec 22, 2024

you should also look at grabbing the interval rate from the networked player's transmitter,

It's now plugged into the interval (using (interval / DefaultInterval) as multiplier)

@dooly123
Copy link
Owner

mint, let me know if you can get this in before this weeks test would help with a lot of people

@hai-vr
Copy link
Contributor Author

hai-vr commented Dec 22, 2024 •
edited
Loading

mint, let me know if you can get this in before this weeks test would help with a lot of people

This change will make it heavier, not lighter.

  • When users are clustered together, it's practically the same rate as the previous load test which is 10 messages per second.
  • With this change, whenever a player is speaking through a avatar that supports face tracking, it would be 30 messages per second.
  • We are around 92 bytes of data per message (not including headers), so that's going from 920 bytes to around 2760 bytes per second.

I would not recommend merging this until after New Years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hai-vr @dooly123