Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional name parameter to assertion functions #2

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

jflan-dd
Copy link
Contributor

@jflan-dd jflan-dd commented Aug 16, 2023

Add the ability to provide an optional name to the various assertSnapshots functions.

This could be used to provide different names for snapshotting a view a multiple sizes or provide a name based on the platform being tested, among various other reasons.

@jflan-dd
Copy link
Contributor Author

@mackoj I'm planning to use this to be able to specify iOS/macOS or UIKit/AppKit in future PRs that will enable testing on multi-platform testing for #1

@jflan-dd jflan-dd merged commit 9e68acb into main Aug 16, 2023
@jflan-dd jflan-dd deleted the jflan/name-parameter branch August 16, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant