Use strong parameters within pre-authorization #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 5, 2019
stokarenko
changed the title
stokarenko
force-pushed
the
use-strong-parameters-for-pre-authorization
branch
2 times, most recently
from
a8ac77b
to
edd8fe9
Compare
nbulaj
reviewed
Jun 6, 2019
stokarenko
force-pushed
the
use-strong-parameters-for-pre-authorization
branch
from
edd8fe9
to
d4a62c3
Compare
houndci-bot
reviewed
Jun 6, 2019
stokarenko
force-pushed
the
use-strong-parameters-for-pre-authorization
branch
from
d4a62c3
to
d78c0b8
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It uses strong parameters within
Doorkeeper::OAuth::PreAuthorization, in order to gracefully ignore non-scalar values passed asscopeparameter for instance, instead of raising the things like: