Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update initializer template documentation #1269

Conversation

fotos
Copy link
Contributor

@fotos fotos commented Jun 7, 2019

Summary

  • Fix the before_successful_authorization example code
  • Fix a broken link towards the Custom Access Token Generator docs
  • Update the link for scopes to gitbook.io

@fotos fotos force-pushed the update-initializer-template-documentation branch from 0f1cf73 to cc950bf Compare June 7, 2019 19:19
@doorkeeper-bot
Copy link

doorkeeper-bot commented Jun 7, 2019

1 Warning
⚠️ There’re library changes, but not tests. That’s OK as long as you’re refactoring existing code.

Generated by 🚫 Danger

Copy link
Member

@nbulaj nbulaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @fotos , thanks for your contribution 🎉

@@ -296,7 +296,7 @@
# or add any other functionality.
#
# before_successful_authorization do |controller|
# Rails.logger.info(params.inspect)
# Rails.logger.info(controller.request.params.inspect)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nbulaj nbulaj merged commit 57b32d7 into doorkeeper-gem:master Jun 7, 2019
@fotos fotos deleted the update-initializer-template-documentation branch June 7, 2019 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants