Fix Ruby 2.7 kwargs warning in InvalidTokenResponse #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
I Run specs and found the following warning in Doorkeeper's code itself. ``` lib/doorkeeper/oauth/invalid_token_response.rb:31: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call ``` Instead of expanding the hash to keyword arguments with double splat, I have rewritten the hash into keyword arguments. It's the same as `Doorkeeper::OAuth::InvalidRequestResponse#description`.
oshow
force-pushed
the
fix-keyword-args-warning
branch
from
476c271
to
4822bc0
Compare
nbulaj
approved these changes
Jan 17, 2020
|
Tested localy and seems like some weird gem broke the specs :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I Run specs and found the following warning in Doorkeeper's code itself.
Instead of expanding the hash to keyword arguments with
double splat, I have rewritten the hash into keyword arguments.
It's the same as
Doorkeeper::OAuth::InvalidRequestResponse#description.