Fix broken tests for older Rails versions #1742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doorkeeper-gem#1736 broke tests for Rails < 7.1 because these versions compared `config.action_dispatch.show_exceptions == false`. Conditionally set this value in the test set up to fix the broken tests.
This was referenced Oct 24, 2024
stanhu
added a commit
to stanhu/doorkeeper-openid_connect
that referenced
this pull request
Nov 22, 2024
In Rails 7.1, `action_dispatch.show_exceptions` should be set to `:none` instead of `false` per rails/rails#45867. This is similar to doorkeeper-gem/doorkeeper#1742
stanhu
added a commit
to stanhu/doorkeeper-openid_connect
that referenced
this pull request
Nov 22, 2024
In Rails 7.1, `action_dispatch.show_exceptions` should be set to `:none` instead of `false` per rails/rails#45867. This is similar to doorkeeper-gem/doorkeeper#1742
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#1736 broke tests for Rails < 7.1 because these versions compared
config.action_dispatch.show_exceptions == false. Conditionally set this value in the test set up to fix the broken tests.Other Information
falsein favor of:all,:none, and:rescuablefor Rails 7.1.