Extract ORMs from doorkeeper, take 2 #648
Conversation
|
@jasl please tell me how you like these changes! I think this is a good way of solving this problem. |
tute
force-pushed
the
extract-orms
branch
2 times, most recently
from
15f5b36
to
9ef5155
Compare
|
Let's me check after work. |
|
@tute I comment in doorkeeper-orms |
tute
force-pushed
the
extract-orms
branch
2 times, most recently
from
7a860a1
to
0b0031e
Compare
| @@ -26,6 +26,5 @@ Gem::Specification.new do |s| | |||
| s.add_development_dependency "timecop", "~> 0.7.0" | |||
| s.add_development_dependency "database_cleaner", "~> 1.3.0" | |||
| s.add_development_dependency "rspec-activemodel-mocks", "~> 1.0.0" | |||
| s.add_development_dependency "bcrypt-ruby", "~> 3.0.1" | |||
| s.add_development_dependency "pry", "~> 0.10.0" | |||
There was a problem hiding this comment.
@jasl can we remove dependencies from here?
|
It looks both PRs are green. Updated documentation in both repos, and renamed the mongodb extensions one. We just need a real mongo doorkeeper application to make sure everything has been tied together correctly. Do you have anyone at hand, @jasl? Thank you! |
|
No problem, I will update our application to doorkeeper edge version and test |
tute
force-pushed
the
extract-orms
branch
2 times, most recently
from
eacfc8d
to
cf38ddc
Compare
This PR removes doorkeeper ORM specifics, in favor of extending it with other rubygems. The specs defined in this project are still considered canonical, and the goal is for extension rubygems to set doorkeeper as a git submodule, and running its test suite against the specific ORM that is being extended. See doorkeeper-gem/doorkeeper-mongodb#2
Extract ORMs from doorkeeper, take 2
|
We have update our developing branch using this gem, if have problem, I will fix |
|
oh I mean doorkeeper-mongo |
|
I created a new Thank you! |
|
In preparation for Rails 3, if we still have changes we didn't do due to backwards compatibility concerns, or we have leftover upgrading warnings, we should change/remove those now. |
|
@jasl could you test doorkeeper 3 with your MongoDB project, so we make sure it works and can release v3 stable? |
|
OK, give me a week to test it stable. |
Related PR: doorkeeper-gem/doorkeeper-mongodb#2
Idea:
doorkeeper-ormsrunsrakedoorkeeper tests after extending with ORMs
To do:
doorkeeper-ormsrenamed todoorkeeper-mongodbspec/*todoorkeeper-mongodb.Both projects see a good portion of their code bases removed, keeping same behavior, test coverage, and getting faster specs. WIN.