Made code responses return the actual time that a token is still valid #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Can you please add notes to the NEWS.md file, and add a regression test? Thanks again! |
| @@ -0,0 +1,32 @@ | |||
| require 'spec_helper' | |||
|
|
|||
| module Doorkeeper::OAuth | |||
There was a problem hiding this comment.
Use nested module/class definitions instead of compact style.
|
Sure, here you go. |
|
Thank you! Merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've spent the last hour debugging what turned out to be a problem with Doorkeeper.
If the
reuse_access_tokenoption is configured, then code responses will always return the token's initialexpires_invalue instead of the remaining time the token is still valid. This PR fixes that ;)