Make configuration and specs ORM independent #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Beautiful changeset, thank you! Can you please improve the commit message, merging the contents of the current commit message and your pull request description? You can see a good example in http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html. Also, can you update the NEWS.md file with a summary of these changes? Thanks again! |
nbulaj
changed the title
* Fix models uniquenes validation error in specs to depend on used ORM
* Extract 'refresh_token_revoked_on_use?' method to AccessToken model
* Fix missed 'reload' method in expect { }.to change { } expectations
|
@tute done. |
|
Thank you! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. This PR fixes a few issues with dependence on the ORM:
ActiveRecord::RecordNotUniqueexceptions, now error class(es) depends on configured ORM. Tests attached.refresh_token_revoked_on_use?in Doorkeeper configuration - was not actually a config option. Extracted toAccessTokenmodel due to it's logic and can be override in any Doorkeeper ORM. Tests attached.expect { ... }.to change { relation.associations.count }expectations - fixed missedreloadmethod to get actual information. Tests attached.