Some TypedArray defineproperty tests are panicing

[mstoykov]

If you enable the sec-integer-indexed-exotic-objects-defineownproperty-p-desc you will see that a bunch of tests are failing such as test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/desc-value-throws.js which panics with (removed irrelevant parts):

panic({0x7b3a80, 0xca1d90})
        runtime/panic.go:1038 +0x215
github.com/dop251/goja.(*float64Array).set(0xc00014dee8, 0x0, {0x0, 0x0})
        github.com/dop251/goja/typedarrays.go:423 +0x28
github.com/dop251/goja.(*typedArrayObject)._putIdx(0xc0006a5b80, 0x0, {0x8de900, 0xc0006fc5a0}, 0x0)
        github.com/dop251/goja/typedarrays.go:518 +0x7b
github.com/dop251/goja.(*typedArrayObject)._defineIdxProperty(0xc0006a5b80, 0xc0006ef2c0, {0xc0006fc540, {0x8de738, 0xc0006f9e30}, 0x0, 0x0, 0x0, {0x0, 0x0}, ...}, ...)
        github.com/dop251/goja/typedarrays.go:565 +0xe7
github.com/dop251/goja.(*typedArrayObject).defineOwnPropertyStr(0xc0006a5b80, {0xc0006e013c, 0x1}, {0xc0006fc540, {0x8de738, 0xc0006f9e30}, 0x0, 0x0, 0x0, {0x0, ...}, ...}, ...)
        github.com/dop251/goja/typedarrays.go:572 +0xca
github.com/dop251/goja.(*Object).defineOwnProperty(0xc0006fc480, {0x8de998, 0xc0006e4d20}, {0xc0006fc540, {0x8de738, 0xc0006f9e30}, 0x0, 0x0, 0x0, {0x0, ...}, ...}, ...)
        github.com/dop251/goja/object.go:1423 +0x153
github.com/dop251/goja.(*Runtime).object_defineProperty(0x7b16e0, {{0x8de738, 0xc0006515f0}, {0xc0006f0d30, 0x3, 0xd}})
        github.com/dop251/goja/builtin_object.go:233 +0x1ec
github.com/dop251/goja.(*vm)._nativeCall(0xc000178c00, 0xc00065d720, 0x3)
        github.com/dop251/goja/vm.go:2544 +0x223
github.com/dop251/goja.call.exec(0x5, 0xc000178c00)
        github.com/dop251/goja/vm.go:2516 +0x6a6
github.com/dop251/goja.(*vm).run(0xc000178c00)
        github.com/dop251/goja/vm.go:401 +0x8b
github.com/dop251/goja.(*vm).try(0xc00011ea7a, 0x9)
        github.com/dop251/goja/vm.go:517 +0x1a4
github.com/dop251/goja.(*vm).runTry(...)
        github.com/dop251/goja/vm.go:522

From my quick investigation

goja/typedarrays.go

Line 515 in a7a3a13

v = v.ToNumber()

this is the line that makes v to be nil. Whether that is an error in ToNumber or the previous creation of the property at

goja/typedarrays.go

Line 563 in a7a3a13

prop, ok := a._defineOwnProperty(unistring.String(strconv.Itoa(idx)), a.getOwnPropIdx(valueInt(idx)), desc, throw)

is ... a more complicated question