Make EOF in JSON.parse human-oriented. #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dop251
reviewed
May 31, 2023
builtin_json.go
Outdated
| @@ -20,6 +21,9 @@ func (r *Runtime) builtinJSON_parse(call FunctionCall) Value { | |||
| d := json.NewDecoder(strings.NewReader(call.Argument(0).toString().String())) | |||
|
|
|||
| value, err := r.builtinJSON_decodeValue(d) | |||
| if errors.Is(err, io.EOF) { | |||
| err = fmt.Errorf("Unexpected end of JSON input (%w)", err) | |||
There was a problem hiding this comment.
It doesn't really make sense to create an error, considering we're only interested in its string value. Also, Go convention is not to begin an error message with a capital letter, so some IDEs would highlight this. It's better to do something like:
panic(r.newError(r.global.SyntaxError, fmt.Sprintf("Unexpected end of JSON input (%v)", err)))There was a problem hiding this comment.
Sure, that makes sense. I've adjusted 👍
|
Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Wrap the
io.EOFinJSON.parseto make it human-oriented.Why?
Resolves: #503