Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuilding docs requirements tree to get the builds working again. #1132

Closed
wants to merge 1 commit into from

Conversation

etsauer
Copy link
Collaborator

@etsauer etsauer commented May 9, 2024

Description

This PR pulls in updated versions of all the packages involved in building our docs with mkdocs. This should fix the broken builds on readthedocs.org

Testing Instructions

  1. Check the readthedocs CI check and make sure that it passes
  2. Check the built docs site and make sure everything looks right

Copy link

openshift-ci bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from etsauer. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
Copy link

openshift-ci bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from etsauer. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Collaborator

@mateusoliveira43 mateusoliveira43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to run make update-requirements and update poetry.lock

@etsauer
Copy link
Collaborator Author

etsauer commented May 14, 2024

Ok, how's this look?

Signed-off-by: Eric Sauer <esauer@redhat.com>
@etsauer
Copy link
Collaborator Author

etsauer commented Aug 22, 2024

/retest

@etsauer etsauer closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants