Skip to content
CI

chore: fix some typos in comment #3690

Sign in to view logs

chore: fix some typos in comment

chore: fix some typos in comment #3690

Triggered via pull request January 20, 2025 09:54
@sunxunlesunxunle
synchronize #759
sunxunle:main
Status Success
Total duration 21m 4s
Artifacts –

ci.yml

on: pull_request
ROS2 Bridge Examples
13m 49s
ROS2 Bridge Examples
Clippy
2m 52s
Clippy
Formatting
16s
Formatting
License Checks
25s
License Checks
Typos
22s
Typos
Matrix: Bench
Matrix: CLI Test
Matrix: cross-check
Matrix: Examples
Matrix: Test
Fit to window
Zoom out
Zoom in

Annotations

84 warnings
Formatting
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Typos
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Typos
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Typos
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Typos
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Typos
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
License Checks
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Bench (ubuntu-latest)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Bench (ubuntu-latest): examples/benchmark/node/src/main.rs#L2
unused import: `Error`
Test (ubuntu-latest)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Test (ubuntu-latest): examples/benchmark/node/src/main.rs#L2
unused import: `Error`
Test (ubuntu-latest): examples/benchmark/node/src/main.rs#L2
unused import: `Error`
Test (ubuntu-latest): examples/benchmark/node/src/main.rs#L2
unused import: `Error`
Clippy
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Clippy: libraries/message/src/lib.rs#L33
returning the result of a `let` binding from a block
Clippy: libraries/message/src/lib.rs#L49
this expression creates a reference which is immediately dereferenced by the compiler
Clippy: libraries/core/src/metadata.rs#L11
unsafe function's docs are missing a `# Safety` section
Clippy: apis/rust/node/src/event_stream/scheduler.rs#L28
useless conversion to the same type: `std::collections::hash_map::Keys<'_, dora_core::config::DataId, (usize, std::collections::VecDeque<event_stream::thread::EventItem>)>`
Clippy: apis/python/operator/src/lib.rs#L179
this `if` has identical blocks
Clippy: binaries/runtime/src/operator/python.rs#L50
this expression creates a reference which is immediately dereferenced by the compiler
Clippy: binaries/runtime/src/operator/shared_lib.rs#L43
this expression creates a reference which is immediately dereferenced by the compiler
Clippy: binaries/daemon/src/spawn.rs#L344
this `if` statement can be collapsed
Clippy: binaries/daemon/src/spawn.rs#L104
this expression creates a reference which is immediately dereferenced by the compiler
Clippy: binaries/daemon/src/lib.rs#L1333
writing `&String` instead of `&str` involves a new object where a slice will do
cross-check (ubuntu-20.04, aarch64-unknown-linux-musl)
dropping unsupported crate type `cdylib` for target `aarch64-unknown-linux-musl`
cross-check (ubuntu-20.04, aarch64-unknown-linux-musl)
`dora-cli` (lib) generated 1 warning
cross-check (ubuntu-20.04, armv7-unknown-linux-musleabihf)
dropping unsupported crate type `cdylib` for target `armv7-unknown-linux-musleabihf`
cross-check (ubuntu-20.04, armv7-unknown-linux-musleabihf)
`dora-cli` (lib) generated 1 warning
Bench (macos-latest): examples/benchmark/node/src/main.rs#L2
unused import: `Error`
Bench (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
Bench (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
Bench (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
Bench (windows-latest): examples/benchmark/node/src/main.rs#L2
unused import: `Error`
Bench (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
Bench (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
CLI Test (ubuntu-latest)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
CLI Test (ubuntu-latest)
unused variable: `node`
CLI Test (ubuntu-latest)
unused variable: `metadata`
CLI Test (ubuntu-latest)
variable does not need to be mutable
CLI Test (macos-latest)
unused variable: `node`
CLI Test (macos-latest)
unused variable: `metadata`
CLI Test (macos-latest)
variable does not need to be mutable
Test (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
Test (windows-latest): examples/benchmark/node/src/main.rs#L2
unused import: `Error`
Test (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
Test (windows-latest): examples/benchmark/node/src/main.rs#L2
unused import: `Error`
Test (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
Test (windows-latest): examples/benchmark/node/src/main.rs#L2
unused import: `Error`
Test (macos-latest): examples/benchmark/node/src/main.rs#L2
unused import: `Error`
Test (macos-latest): examples/benchmark/node/src/main.rs#L2
unused import: `Error`
Test (macos-latest): examples/benchmark/node/src/main.rs#L2
unused import: `Error`
Examples (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
Examples (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
Examples (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
Examples (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
Examples (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
Examples (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
Examples (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
Examples (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
Examples (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
Examples (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
Examples (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
Examples (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
Examples (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
Examples (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
Examples (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
Examples (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
Examples (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
Examples (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
CLI Test (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
CLI Test (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
CLI Test (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
CLI Test (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
CLI Test (windows-latest)
unused variable: `node`
CLI Test (windows-latest)
unused variable: `metadata`
CLI Test (windows-latest)
variable does not need to be mutable
CLI Test (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
CLI Test (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
CLI Test (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
CLI Test (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
CLI Test (windows-latest): libraries/message/src/daemon_to_node.rs#L1
unused import: `path::PathBuf`
cross-check (macos-13, aarch64-apple-darwin)
spurious network error (3 tries remaining): failed to get successful HTTP response from `https://static.crates.io/crates/proc-macro-error-attr/1.0.4/download` (151.101.2.137), got 502
cross-check (macos-13, aarch64-apple-darwin)
spurious network error (3 tries remaining): failed to get successful HTTP response from `https://static.crates.io/crates/libc/0.2.169/download` (151.101.2.137), got 502
cross-check (macos-13, aarch64-apple-darwin)
spurious network error (3 tries remaining): failed to get successful HTTP response from `https://static.crates.io/crates/cfg_aliases/0.2.1/download` (151.101.2.137), got 502