Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable bind addrs #471

Merged
merged 11 commits into from
Apr 18, 2024
Merged

Configurable bind addrs #471

merged 11 commits into from
Apr 18, 2024

Commits on Apr 16, 2024

  1. feat: add bind configuration for the inter_daemon listener 

    Ref: dora-rs#459
    @Michael-J-Ward
    Michael-J-Ward committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    f659022 View commit details
    Browse the repository at this point in the history

  2. feat: add bind configuration for coordination daemon 

    Ref: dora-rs#459
    @Michael-J-Ward
    Michael-J-Ward committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    3a6323f View commit details
    Browse the repository at this point in the history

  3. Increase log level of 'disconnecting daemons' message to error

    @phil-opp
    phil-opp committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    58eac29 View commit details
    Browse the repository at this point in the history

  4. Delay watchdog disconnect to 30 seconds

    @phil-opp
    phil-opp committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    279530e View commit details
    Browse the repository at this point in the history

  5. update dora_coordinator::start to return bound addr instead of just t… 

    …he port
    @Michael-J-Ward
    Michael-J-Ward committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    1ba763c View commit details
    Browse the repository at this point in the history

  6. revert to daemons listening to 127.0.0.1 by default 

    clients can not connect to `0.0.0.0` on windows.
    @Michael-J-Ward
    Michael-J-Ward committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    4af82a4 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Revert "revert to daemons listening to 127.0.0.1 by default" 

    This reverts commit 4af82a4.
    @phil-opp
    phil-opp committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    e76f497 View commit details
    Browse the repository at this point in the history

  2. Revert "update dora_coordinator::start to return bound addr instead o… 

    …f just the port"

This reverts commit 1ba763c.
    @phil-opp
    phil-opp committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    6115ddb View commit details
    Browse the repository at this point in the history

  3. Fix: Use peer_addr of incoming daemon register request for listen s… 

    …ocket

We are not interested in the local bind address of the daemon. Instead, we want to use the IP address under which the daemon is available from other machines.

This should also avoids the issue that connecting to 0.0.0.0 is not possible on Windows (we want to use 0.0.0.0 as default bind address).
    @phil-opp
    phil-opp committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    01707fc View commit details
    Browse the repository at this point in the history

  4. refactor: use addr instead of bind to configure daemon listen add… 

    …ress
    @Michael-J-Ward
    Michael-J-Ward committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    a9bfafd View commit details
    Browse the repository at this point in the history

  5. refactor: rename coordinator listen port configuration to addr

    @Michael-J-Ward
    Michael-J-Ward committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    431d72c View commit details
    Browse the repository at this point in the history